leviathonbeast/restcountries
1
0
Fork 0
mirror of https://gitlab.com/restcountries/restcountries.git synced 2026-03-31 15:07:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

revert for 5 days: endpoint all must specify the fields

Browse Source
This commit is contained in:
Alejandro
2025-06-04 17:05:33 -05:00
parent 5e1ac7624e
commit 8c264c0a6c
3 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/restcountries/controller/CountryControllerV2.java
-7
View File
@@ -27,13 +27,6 @@ public class CountryControllerV2 {
@Get(uri = "all", produces = MediaType.APPLICATION_JSON) @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
public Object getAllCountries(@QueryValue("fields") Optional<String> fields) { public Object getAllCountries(@QueryValue("fields") Optional<String> fields) {
if (fields.isEmpty()) {
return ControllerHelper.badAllRequest();
}
var totalFields = fields.get().split(",").length;
if (totalFields > 10) {
return ControllerHelper.badAllRequest();
}
List<Country> countries = CountryServiceV2.getInstance().getAll(); List<Country> countries = CountryServiceV2.getInstance().getAll();
return checkFieldsAndParseCountries(fields, countries); return checkFieldsAndParseCountries(fields, countries);
} }
src/main/java/com/restcountries/controller/CountryControllerV3.java
-7
View File
@@ -18,13 +18,6 @@ public class CountryControllerV3 extends ControllerV3Helper {
@Get(uri = "all", produces = MediaType.APPLICATION_JSON) @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
public HttpResponse<Object> getAllCountries(@QueryValue("fields") Optional<String> fields) { public HttpResponse<Object> getAllCountries(@QueryValue("fields") Optional<String> fields) {
if (fields.isEmpty()) {
return ControllerHelper.badAllRequest();
}
var totalFields = fields.get().split(",").length;
if (totalFields > 10) {
return ControllerHelper.badAllRequest();
}
var countries = CountryServiceV3.getInstance().getAll(); var countries = CountryServiceV3.getInstance().getAll();
return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries)); return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries));
} }
src/main/java/com/restcountries/controller/CountryControllerV31.java
-7
View File
@@ -19,13 +19,6 @@ public class CountryControllerV31 extends ControllerV3Helper {
@Get(uri = "all", produces = MediaType.APPLICATION_JSON) @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
@Schema(name = "RestCountries") @Schema(name = "RestCountries")
public Object getAllCountries(@QueryValue("fields") Optional<String> fields) { public Object getAllCountries(@QueryValue("fields") Optional<String> fields) {
if (fields.isEmpty()) {
return ControllerHelper.badAllRequest();
}
var totalFields = fields.get().split(",").length;
if (totalFields > 10) {
return ControllerHelper.badAllRequest();
}
var countries = CountryServiceV31.getInstance().getAll(); var countries = CountryServiceV31.getInstance().getAll();
return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries)); return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries));
} }