Merge branch 'feature/all-endpoints-require-fields' into 'master'

#265 endpoint 'all' requires fields to be specified

See merge request restcountries/restcountries!88

src/main/java/com/restcountries/controller/CountryControllerV2.java

@@ -27,6 +27,13 @@ public class CountryControllerV2 {
 
   @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
   public Object getAllCountries(@QueryValue("fields") Optional<String> fields) {
+    if (fields.isEmpty()) {
+      return ControllerHelper.badAllRequest();
+    }
+    var totalFields = fields.get().split(",").length;
+    if (totalFields > 10) {
+      return ControllerHelper.badAllRequest();
+    }
     List<Country> countries = CountryServiceV2.getInstance().getAll();
     return checkFieldsAndParseCountries(fields, countries);
   }

src/main/java/com/restcountries/controller/CountryControllerV3.java

@@ -18,6 +18,13 @@ public class CountryControllerV3 extends ControllerV3Helper {
 
   @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
   public HttpResponse<Object> getAllCountries(@QueryValue("fields") Optional<String> fields) {
+    if (fields.isEmpty()) {
+      return ControllerHelper.badAllRequest();
+    }
+    var totalFields = fields.get().split(",").length;
+    if (totalFields > 10) {
+      return ControllerHelper.badAllRequest();
+    }
     var countries = CountryServiceV3.getInstance().getAll();
     return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries));
   }

src/main/java/com/restcountries/controller/CountryControllerV31.java

@@ -19,6 +19,13 @@ public class CountryControllerV31 extends ControllerV3Helper {
     @Get(uri = "all", produces = MediaType.APPLICATION_JSON)
     @Schema(name = "RestCountries")
     public Object getAllCountries(@QueryValue("fields") Optional<String> fields) {
+        if (fields.isEmpty()) {
+            return ControllerHelper.badAllRequest();
+        }
+        var totalFields = fields.get().split(",").length;
+        if (totalFields > 10) {
+            return ControllerHelper.badAllRequest();
+        }
         var countries = CountryServiceV31.getInstance().getAll();
         return ControllerHelper.ok(checkFieldsAndParseCountries(fields, countries));
     }