Closes #138: Searching for an unknown country won't return an exception

This commit is contained in:
Alejandro Matos
2022-07-07 21:58:18 -05:00
parent 1ec9a0c785
commit 5681387d9c
2 changed files with 20 additions and 22 deletions
-2
View File
@@ -131,8 +131,6 @@
<artifactId>maven-compiler-plugin</artifactId> <artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version> <version>3.8.1</version>
<configuration> <configuration>
<!-- Uncomment to enable incremental compilation -->
<!-- <useIncrementalCompilation>false</useIncrementalCompilation> -->
<annotationProcessorPaths> <annotationProcessorPaths>
<path> <path>
<groupId>io.micronaut</groupId> <groupId>io.micronaut</groupId>
@@ -6,12 +6,12 @@ import dev.amatos.restcountries.domain.ICountryRestSymbols;
import dev.amatos.restcountries.domain.ResponseEntity; import dev.amatos.restcountries.domain.ResponseEntity;
import dev.amatos.restcountries.domain.base.BaseCountry; import dev.amatos.restcountries.domain.base.BaseCountry;
import io.micronaut.http.HttpResponse; import io.micronaut.http.HttpResponse;
import jakarta.ws.rs.core.Response;
import jakarta.ws.rs.core.Response.Status;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status;
public class ControllerHelper { public class ControllerHelper {
@@ -92,30 +92,30 @@ public class ControllerHelper {
} }
protected static HttpResponse<Object> notFound() { protected static HttpResponse<Object> notFound() {
var gson = new Gson(); return HttpResponse.notFound().body(
var notFound = Response new ResponseEntity(
.status(Status.NOT_FOUND) Response.Status.NOT_FOUND.getStatusCode(),
.entity(gson.toJson(new ResponseEntity(Response.Status.NOT_FOUND.getStatusCode(), Response.Status.NOT_FOUND.getReasonPhrase()
Response.Status.NOT_FOUND.getReasonPhrase()))).build().getEntity(); )
return HttpResponse.notFound(notFound); );
} }
protected static HttpResponse<Object> internalError() { protected static HttpResponse<Object> internalError() {
var gson = new Gson(); return HttpResponse.serverError().body(
var notFound = Response new ResponseEntity(
.status(Status.INTERNAL_SERVER_ERROR) Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(),
.entity(gson.toJson(new ResponseEntity(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(), Response.Status.INTERNAL_SERVER_ERROR.getReasonPhrase()
Response.Status.INTERNAL_SERVER_ERROR.getReasonPhrase()))).build().getEntity(); )
return HttpResponse.serverError(notFound); );
} }
protected static HttpResponse<Object> badRequest() { protected static HttpResponse<Object> badRequest() {
var gson = new Gson(); return HttpResponse.badRequest().body(
var notFound = Response new ResponseEntity(
.status(Status.BAD_REQUEST) Response.Status.BAD_REQUEST.getStatusCode(),
.entity(gson.toJson(new ResponseEntity(Response.Status.BAD_REQUEST.getStatusCode(), Response.Status.BAD_REQUEST.getReasonPhrase()
Response.Status.BAD_REQUEST.getReasonPhrase()))).build().getEntity(); )
return HttpResponse.badRequest(notFound); );
} }
protected static Object parsedCountry(Set<? extends BaseCountry> countries, String fields) { protected static Object parsedCountry(Set<? extends BaseCountry> countries, String fields) {