leviathonbeast/php-flasher
1
0
Fork 0
mirror of https://github.com/php-flasher/php-flasher.git synced 2026-03-31 15:07:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: validate alias attribute in PresenterCompilerPass

Browse Source 
Add validation to ensure services tagged with 'flasher.presenter' have
the required 'alias' attribute. Previously, accessing $attributes['alias']
without checking would throw an "Undefined array key" error.

Now throws a clear InvalidArgumentException with a helpful message.
This commit is contained in:
Younes ENNAJI
2026-03-01 20:01:12 +00:00
parent 5202c86107
commit fd36c2ec0c
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Symfony/DependencyInjection/Compiler/PresenterCompilerPassTest.php
+14
View File
@@ -54,4 +54,18 @@ final class PresenterCompilerPassTest extends TestCase
$this->assertCount(0, $definition->getMethodCalls(), 'No method calls should be made when no tagged services exist.');
}
public function testProcessThrowsExceptionWhenAliasIsMissing(): void
{
$definition = new Definition();
$this->container->setDefinition('flasher.response_manager', $definition);
// Register a service without the required 'alias' attribute
$this->container->register('presenter_without_alias')->addTag('flasher.presenter');
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Service "presenter_without_alias" tagged with "flasher.presenter" must have an "alias" attribute.');
$this->compilerPass->process($this->container);
}
}