fix: issue when enabling/disabling https certs

internal/service/dns.go

@@ -52,7 +52,7 @@ func (s *Service) SetDNSConfig(ctx context.Context, req *connect.Request[api.Set
 
 	tailnet.DNSConfig = domain.DNSConfig{
 		MagicDNS:          dnsConfig.MagicDns,
-		HttpsCertsEnabled: dnsConfig.HttpsCerts,
+		HttpsCertsEnabled: s.dnsProvider != nil && dnsConfig.HttpsCerts,
 		OverrideLocalDNS:  dnsConfig.OverrideLocalDns,
 		Nameservers:       dnsConfig.Nameservers,
 		Routes:            apiRoutesToDomainRoutes(dnsConfig.Routes),
@@ -64,7 +64,13 @@ func (s *Service) SetDNSConfig(ctx context.Context, req *connect.Request[api.Set
 
 	s.sessionManager.NotifyAll(tailnet.ID)
 
-	resp := &api.SetDNSConfigResponse{Config: dnsConfig}
+	resp := &api.SetDNSConfigResponse{
+		Config: domainDNSConfigToApiDNSConfig(tailnet),
+	}
+
+	if dnsConfig.HttpsCerts && s.dnsProvider == nil {
+		resp.Message = "# HTTPS Certs cannot be enabled because a DNS provider is not properly configured"
+	}
 
 	return connect.NewResponse(resp), nil
 }

internal/service/service.go

@@ -6,15 +6,17 @@ import (
 	"github.com/jsiebens/ionscale/internal/auth"
 	"github.com/jsiebens/ionscale/internal/config"
 	"github.com/jsiebens/ionscale/internal/core"
+	"github.com/jsiebens/ionscale/internal/dns"
 	"github.com/jsiebens/ionscale/internal/domain"
 	"github.com/jsiebens/ionscale/internal/version"
 	api "github.com/jsiebens/ionscale/pkg/gen/ionscale/v1"
 )
 
-func NewService(config *config.Config, authProvider auth.Provider, repository domain.Repository, sessionManager core.PollMapSessionManager) *Service {
+func NewService(config *config.Config, authProvider auth.Provider, dnsProvider dns.Provider, repository domain.Repository, sessionManager core.PollMapSessionManager) *Service {
 	return &Service{
 		config:         config,
 		authProvider:   authProvider,
+		dnsProvider:    dnsProvider,
 		repository:     repository,
 		sessionManager: sessionManager,
 	}
@@ -23,6 +25,7 @@ func NewService(config *config.Config, authProvider auth.Provider, repository do
 type Service struct {
 	config         *config.Config
 	authProvider   auth.Provider
+	dnsProvider    dns.Provider
 	repository     domain.Repository
 	sessionManager core.PollMapSessionManager
 }